A bit of clean-up in TagMap by dougqh · Pull Request #10164 · DataDog/dd-trace-java

dougqh · 2025-12-10T22:33:56Z

What Does This Do

A bit of clean-up in TagMap

Motivation

Making empty static & final to clarify thread safety
Removing unnecessary package qualification on forEach parameters

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any useful labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

- Making empty final -- and static even though static is redundant here - Removing unnecessary package qualification on forEach

github-actions · 2025-12-10T22:34:06Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

pr-commenter · 2025-12-10T23:17:46Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	dougqh/tagmap-cleanup
git_commit_date	1765481941	1765485224
git_commit_sha	`f2a8d05`	`854633b`
release_version	1.57.0-SNAPSHOT~f2a8d05e73	1.57.0-SNAPSHOT~854633b0ea

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1765486976	1765486976
ci_job_id	1288905890	1288905890
ci_pipeline_id	86334251	86334251
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-insg4mtf 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-insg4mtf 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~854633b0ea, baseline=1.57.0-SNAPSHOT~f2a8d05e73

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.09 s) : 0, 1090104
Total [baseline] (10.894 s) : 0, 10894348
Agent [candidate] (1.083 s) : 0, 1083011
Total [candidate] (10.886 s) : 0, 10885830
section appsec
Agent [baseline] (1.282 s) : 0, 1282287
Total [baseline] (11.106 s) : 0, 11106049
Agent [candidate] (1.271 s) : 0, 1270812
Total [candidate] (11.115 s) : 0, 11114850
section iast
Agent [baseline] (1.224 s) : 0, 1224249
Total [baseline] (11.151 s) : 0, 11150846
Agent [candidate] (1.224 s) : 0, 1223892
Total [candidate] (11.258 s) : 0, 11258090
section profiling
Agent [baseline] (1.206 s) : 0, 1205666
Total [baseline] (11.022 s) : 0, 11021804
Agent [candidate] (1.206 s) : 0, 1205513
Total [candidate] (11.051 s) : 0, 11050737

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.09 s	-
Agent	appsec	1.282 s	192.183 ms (17.6%)
Agent	iast	1.224 s	134.145 ms (12.3%)
Agent	profiling	1.206 s	115.562 ms (10.6%)
Total	tracing	10.894 s	-
Total	appsec	11.106 s	211.7 ms (1.9%)
Total	iast	11.151 s	256.498 ms (2.4%)
Total	profiling	11.022 s	127.456 ms (1.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.083 s	-
Agent	appsec	1.271 s	187.801 ms (17.3%)
Agent	iast	1.224 s	140.88 ms (13.0%)
Agent	profiling	1.206 s	122.501 ms (11.3%)
Total	tracing	10.886 s	-
Total	appsec	11.115 s	229.019 ms (2.1%)
Total	iast	11.258 s	372.26 ms (3.4%)
Total	profiling	11.051 s	164.907 ms (1.5%)

gantt
    title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~854633b0ea, baseline=1.57.0-SNAPSHOT~f2a8d05e73

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.214 ms) : 0, 1214
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (653.919 ms) : 0, 653919
BytebuddyAgent [candidate] (649.481 ms) : 0, 649481
GlobalTracer [baseline] (283.813 ms) : 0, 283813
GlobalTracer [candidate] (282.528 ms) : 0, 282528
AppSec [baseline] (32.738 ms) : 0, 32738
AppSec [candidate] (32.451 ms) : 0, 32451
Debugger [baseline] (68.851 ms) : 0, 68851
Debugger [candidate] (68.469 ms) : 0, 68469
Remote Config [baseline] (645.721 µs) : 0, 646
Remote Config [candidate] (619.632 µs) : 0, 620
Telemetry [baseline] (9.222 ms) : 0, 9222
Telemetry [candidate] (9.1 ms) : 0, 9100
Flare Poller [baseline] (3.896 ms) : 0, 3896
Flare Poller [candidate] (3.743 ms) : 0, 3743
section appsec
crashtracking [baseline] (1.216 ms) : 0, 1216
crashtracking [candidate] (1.204 ms) : 0, 1204
BytebuddyAgent [baseline] (700.749 ms) : 0, 700749
BytebuddyAgent [candidate] (693.42 ms) : 0, 693420
GlobalTracer [baseline] (263.047 ms) : 0, 263047
GlobalTracer [candidate] (260.448 ms) : 0, 260448
AppSec [baseline] (175.433 ms) : 0, 175433
AppSec [candidate] (175.268 ms) : 0, 175268
Debugger [baseline] (66.967 ms) : 0, 66967
Debugger [candidate] (66.512 ms) : 0, 66512
Remote Config [baseline] (726.417 µs) : 0, 726
Remote Config [candidate] (710.446 µs) : 0, 710
Telemetry [baseline] (9.067 ms) : 0, 9067
Telemetry [candidate] (8.974 ms) : 0, 8974
Flare Poller [baseline] (4.057 ms) : 0, 4057
Flare Poller [candidate] (3.92 ms) : 0, 3920
IAST [baseline] (25.205 ms) : 0, 25205
IAST [candidate] (24.719 ms) : 0, 24719
section iast
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (791.381 ms) : 0, 791381
BytebuddyAgent [candidate] (790.94 ms) : 0, 790940
GlobalTracer [baseline] (256.209 ms) : 0, 256209
GlobalTracer [candidate] (255.662 ms) : 0, 255662
AppSec [baseline] (35.187 ms) : 0, 35187
AppSec [candidate] (35.391 ms) : 0, 35391
Debugger [baseline] (65.615 ms) : 0, 65615
Debugger [candidate] (65.956 ms) : 0, 65956
Remote Config [baseline] (544.274 µs) : 0, 544
Remote Config [candidate] (547.115 µs) : 0, 547
Telemetry [baseline] (8.4 ms) : 0, 8400
Telemetry [candidate] (8.454 ms) : 0, 8454
Flare Poller [baseline] (3.496 ms) : 0, 3496
Flare Poller [candidate] (3.472 ms) : 0, 3472
IAST [baseline] (26.873 ms) : 0, 26873
IAST [candidate] (26.999 ms) : 0, 26999
section profiling
ProfilingAgent [baseline] (97.46 ms) : 0, 97460
ProfilingAgent [candidate] (98.05 ms) : 0, 98050
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (702.251 ms) : 0, 702251
BytebuddyAgent [candidate] (702.017 ms) : 0, 702017
GlobalTracer [baseline] (221.168 ms) : 0, 221168
GlobalTracer [candidate] (220.954 ms) : 0, 220954
AppSec [baseline] (32.524 ms) : 0, 32524
AppSec [candidate] (32.231 ms) : 0, 32231
Debugger [baseline] (67.83 ms) : 0, 67830
Debugger [candidate] (68.091 ms) : 0, 68091
Remote Config [baseline] (668.68 µs) : 0, 669
Remote Config [candidate] (642.255 µs) : 0, 642
Telemetry [baseline] (9.079 ms) : 0, 9079
Telemetry [candidate] (8.906 ms) : 0, 8906
Flare Poller [baseline] (3.751 ms) : 0, 3751
Flare Poller [candidate] (3.802 ms) : 0, 3802
Profiling [baseline] (98.041 ms) : 0, 98041
Profiling [candidate] (98.639 ms) : 0, 98639

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~854633b0ea, baseline=1.57.0-SNAPSHOT~f2a8d05e73

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081435
Total [baseline] (8.747 s) : 0, 8746585
Agent [candidate] (1.08 s) : 0, 1079626
Total [candidate] (8.724 s) : 0, 8723557
section iast
Agent [baseline] (1.231 s) : 0, 1230502
Total [baseline] (9.488 s) : 0, 9488046
Agent [candidate] (1.219 s) : 0, 1219391
Total [candidate] (9.468 s) : 0, 9467636

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.081 s	-
Agent	iast	1.231 s	149.067 ms (13.8%)
Total	tracing	8.747 s	-
Total	iast	9.488 s	741.461 ms (8.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.08 s	-
Agent	iast	1.219 s	139.764 ms (12.9%)
Total	tracing	8.724 s	-
Total	iast	9.468 s	744.079 ms (8.5%)

gantt
    title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~854633b0ea, baseline=1.57.0-SNAPSHOT~f2a8d05e73

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (649.734 ms) : 0, 649734
BytebuddyAgent [candidate] (648.156 ms) : 0, 648156
GlobalTracer [baseline] (282.057 ms) : 0, 282057
GlobalTracer [candidate] (282.153 ms) : 0, 282153
AppSec [baseline] (32.342 ms) : 0, 32342
AppSec [candidate] (32.177 ms) : 0, 32177
Debugger [baseline] (67.114 ms) : 0, 67114
Debugger [candidate] (67.077 ms) : 0, 67077
Remote Config [baseline] (657.172 µs) : 0, 657
Remote Config [candidate] (634.74 µs) : 0, 635
Telemetry [baseline] (9.015 ms) : 0, 9015
Telemetry [candidate] (9.005 ms) : 0, 9005
Flare Poller [baseline] (3.792 ms) : 0, 3792
Flare Poller [candidate] (3.727 ms) : 0, 3727
section iast
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (796.423 ms) : 0, 796423
BytebuddyAgent [candidate] (788.316 ms) : 0, 788316
GlobalTracer [baseline] (257.298 ms) : 0, 257298
GlobalTracer [candidate] (255.491 ms) : 0, 255491
AppSec [baseline] (35.445 ms) : 0, 35445
AppSec [candidate] (35.363 ms) : 0, 35363
Debugger [baseline] (64.757 ms) : 0, 64757
Debugger [candidate] (64.497 ms) : 0, 64497
Remote Config [baseline] (565.85 µs) : 0, 566
Remote Config [candidate] (533.41 µs) : 0, 533
Telemetry [baseline] (8.55 ms) : 0, 8550
Telemetry [candidate] (8.371 ms) : 0, 8371
Flare Poller [baseline] (3.506 ms) : 0, 3506
Flare Poller [candidate] (3.434 ms) : 0, 3434
IAST [baseline] (27.18 ms) : 0, 27180
IAST [candidate] (26.759 ms) : 0, 26759

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	dougqh/tagmap-cleanup
git_commit_date	1765481941	1765485224
git_commit_sha	`f2a8d05`	`854633b`
release_version	1.57.0-SNAPSHOT~f2a8d05e73	1.57.0-SNAPSHOT~854633b0ea

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1765487536	1765487536
ci_job_id	1288905891	1288905891
ci_pipeline_id	86334251	86334251
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-ln8fzx75 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-ln8fzx75 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 20 metrics, 16 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~854633b0ea, baseline=1.57.0-SNAPSHOT~f2a8d05e73
    dateFormat X
    axisFormat %s
section baseline
no_agent (18.976 ms) : 18789, 19162
.   : milestone, 18976,
appsec (18.567 ms) : 18380, 18754
.   : milestone, 18567,
code_origins (17.783 ms) : 17602, 17964
.   : milestone, 17783,
iast (17.61 ms) : 17432, 17788
.   : milestone, 17610,
profiling (18.354 ms) : 18171, 18537
.   : milestone, 18354,
tracing (17.991 ms) : 17810, 18172
.   : milestone, 17991,
section candidate
no_agent (18.167 ms) : 17980, 18353
.   : milestone, 18167,
appsec (18.487 ms) : 18300, 18673
.   : milestone, 18487,
code_origins (17.897 ms) : 17721, 18073
.   : milestone, 17897,
iast (17.577 ms) : 17404, 17750
.   : milestone, 17577,
profiling (18.424 ms) : 18240, 18608
.   : milestone, 18424,
tracing (17.738 ms) : 17556, 17920
.   : milestone, 17738,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	18.976 ms [18.789 ms, 19.162 ms]	-
appsec	18.567 ms [18.38 ms, 18.754 ms]	-408.693 µs (-2.2%)
code_origins	17.783 ms [17.602 ms, 17.964 ms]	-1.192 ms (-6.3%)
iast	17.61 ms [17.432 ms, 17.788 ms]	-1.366 ms (-7.2%)
profiling	18.354 ms [18.171 ms, 18.537 ms]	-622.014 µs (-3.3%)
tracing	17.991 ms [17.81 ms, 18.172 ms]	-984.75 µs (-5.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	18.167 ms [17.98 ms, 18.353 ms]	-
appsec	18.487 ms [18.3 ms, 18.673 ms]	319.895 µs (1.8%)
code_origins	17.897 ms [17.721 ms, 18.073 ms]	-269.616 µs (-1.5%)
iast	17.577 ms [17.404 ms, 17.75 ms]	-589.85 µs (-3.2%)
profiling	18.424 ms [18.24 ms, 18.608 ms]	257.387 µs (1.4%)
tracing	17.738 ms [17.556 ms, 17.92 ms]	-429.067 µs (-2.4%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~854633b0ea, baseline=1.57.0-SNAPSHOT~f2a8d05e73
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.223 ms) : 1211, 1235
.   : milestone, 1223,
iast (3.224 ms) : 3182, 3266
.   : milestone, 3224,
iast_FULL (5.734 ms) : 5677, 5791
.   : milestone, 5734,
iast_GLOBAL (3.685 ms) : 3629, 3740
.   : milestone, 3685,
profiling (2.003 ms) : 1985, 2021
.   : milestone, 2003,
tracing (1.873 ms) : 1858, 1889
.   : milestone, 1873,
section candidate
no_agent (1.187 ms) : 1174, 1200
.   : milestone, 1187,
iast (3.201 ms) : 3155, 3246
.   : milestone, 3201,
iast_FULL (5.794 ms) : 5735, 5853
.   : milestone, 5794,
iast_GLOBAL (3.702 ms) : 3641, 3763
.   : milestone, 3702,
profiling (2.084 ms) : 2065, 2102
.   : milestone, 2084,
tracing (1.81 ms) : 1795, 1824
.   : milestone, 1810,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.223 ms [1.211 ms, 1.235 ms]	-
iast	3.224 ms [3.182 ms, 3.266 ms]	2.001 ms (163.6%)
iast_FULL	5.734 ms [5.677 ms, 5.791 ms]	4.511 ms (368.8%)
iast_GLOBAL	3.685 ms [3.629 ms, 3.74 ms]	2.461 ms (201.2%)
profiling	2.003 ms [1.985 ms, 2.021 ms]	779.982 µs (63.8%)
tracing	1.873 ms [1.858 ms, 1.889 ms]	650.358 µs (53.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.187 ms [1.174 ms, 1.2 ms]	-
iast	3.201 ms [3.155 ms, 3.246 ms]	2.014 ms (169.7%)
iast_FULL	5.794 ms [5.735 ms, 5.853 ms]	4.607 ms (388.1%)
iast_GLOBAL	3.702 ms [3.641 ms, 3.763 ms]	2.515 ms (211.9%)
profiling	2.084 ms [2.065 ms, 2.102 ms]	896.635 µs (75.5%)
tracing	1.81 ms [1.795 ms, 1.824 ms]	622.674 µs (52.5%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	dougqh/tagmap-cleanup
git_commit_date	1765481941	1765485224
git_commit_sha	`f2a8d05`	`854633b`
release_version	1.57.0-SNAPSHOT~f2a8d05e73	1.57.0-SNAPSHOT~854633b0ea

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1765487220	1765487220
ci_job_id	1288905892	1288905892
ci_pipeline_id	86334251	86334251
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-3ahm3t27 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-3ahm3t27 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~854633b0ea, baseline=1.57.0-SNAPSHOT~f2a8d05e73
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.48 ms) : 1468, 1491
.   : milestone, 1480,
appsec (3.741 ms) : 3523, 3959
.   : milestone, 3741,
iast (2.212 ms) : 2148, 2276
.   : milestone, 2212,
iast_GLOBAL (2.266 ms) : 2201, 2331
.   : milestone, 2266,
profiling (2.071 ms) : 2019, 2123
.   : milestone, 2071,
tracing (2.057 ms) : 2006, 2107
.   : milestone, 2057,
section candidate
no_agent (1.476 ms) : 1465, 1488
.   : milestone, 1476,
appsec (3.723 ms) : 3503, 3943
.   : milestone, 3723,
iast (2.216 ms) : 2152, 2281
.   : milestone, 2216,
iast_GLOBAL (2.247 ms) : 2183, 2311
.   : milestone, 2247,
profiling (2.092 ms) : 2038, 2146
.   : milestone, 2092,
tracing (2.047 ms) : 1996, 2097
.   : milestone, 2047,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.48 ms [1.468 ms, 1.491 ms]	-
appsec	3.741 ms [3.523 ms, 3.959 ms]	2.262 ms (152.9%)
iast	2.212 ms [2.148 ms, 2.276 ms]	732.366 µs (49.5%)
iast_GLOBAL	2.266 ms [2.201 ms, 2.331 ms]	786.362 µs (53.1%)
profiling	2.071 ms [2.019 ms, 2.123 ms]	591.495 µs (40.0%)
tracing	2.057 ms [2.006 ms, 2.107 ms]	576.938 µs (39.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.465 ms, 1.488 ms]	-
appsec	3.723 ms [3.503 ms, 3.943 ms]	2.247 ms (152.2%)
iast	2.216 ms [2.152 ms, 2.281 ms]	740.113 µs (50.1%)
iast_GLOBAL	2.247 ms [2.183 ms, 2.311 ms]	770.921 µs (52.2%)
profiling	2.092 ms [2.038 ms, 2.146 ms]	615.317 µs (41.7%)
tracing	2.047 ms [1.996 ms, 2.097 ms]	570.637 µs (38.7%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~854633b0ea, baseline=1.57.0-SNAPSHOT~f2a8d05e73
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.371 s) : 15371000, 15371000
.   : milestone, 15371000,
appsec (14.906 s) : 14906000, 14906000
.   : milestone, 14906000,
iast (18.402 s) : 18402000, 18402000
.   : milestone, 18402000,
iast_GLOBAL (17.801 s) : 17801000, 17801000
.   : milestone, 17801000,
profiling (14.714 s) : 14714000, 14714000
.   : milestone, 14714000,
tracing (14.53 s) : 14530000, 14530000
.   : milestone, 14530000,
section candidate
no_agent (15.259 s) : 15259000, 15259000
.   : milestone, 15259000,
appsec (14.81 s) : 14810000, 14810000
.   : milestone, 14810000,
iast (18.348 s) : 18348000, 18348000
.   : milestone, 18348000,
iast_GLOBAL (18.066 s) : 18066000, 18066000
.   : milestone, 18066000,
profiling (14.413 s) : 14413000, 14413000
.   : milestone, 14413000,
tracing (14.526 s) : 14526000, 14526000
.   : milestone, 14526000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.371 s [15.371 s, 15.371 s]	-
appsec	14.906 s [14.906 s, 14.906 s]	-465.0 ms (-3.0%)
iast	18.402 s [18.402 s, 18.402 s]	3.031 s (19.7%)
iast_GLOBAL	17.801 s [17.801 s, 17.801 s]	2.43 s (15.8%)
profiling	14.714 s [14.714 s, 14.714 s]	-657.0 ms (-4.3%)
tracing	14.53 s [14.53 s, 14.53 s]	-841.0 ms (-5.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.259 s [15.259 s, 15.259 s]	-
appsec	14.81 s [14.81 s, 14.81 s]	-449.0 ms (-2.9%)
iast	18.348 s [18.348 s, 18.348 s]	3.089 s (20.2%)
iast_GLOBAL	18.066 s [18.066 s, 18.066 s]	2.807 s (18.4%)
profiling	14.413 s [14.413 s, 14.413 s]	-846.0 ms (-5.5%)
tracing	14.526 s [14.526 s, 14.526 s]	-733.0 ms (-4.8%)

amarziali · 2025-12-11T08:23:45Z

internal-api/src/main/java/datadog/trace/api/TagMap.java

 public interface TagMap extends Map<String, Object>, Iterable<TagMap.Entry> {
  /** Immutable empty TagMap - similar to {@link Collections#emptyMap()} */
-  TagMap EMPTY = TagMapFactory.INSTANCE.empty();
+  static final TagMap EMPTY = TagMapFactory.INSTANCE.empty();


The fields declared on an interface are already implicitly static final so IMHO this is redundant

Yes, I know, but I prefer to be explicit.
I want to see final, so that I know it is obviously correct.

I personally think that we should omit that since it does not improve the readability. A lot of other projects are explicitly suggesting not to do it (i.e. openjdk -> https://cr.openjdk.org/~alundblad/styleguide/index-v6.html).

At least for final, I think it is good to be explicit. Especially given that we have a lot of contributors that aren't regularly working in Java, so including static final sets an example that works in both classes & interfaces.

amarziali

the PR is safe to merge - I anyway left a note about the redundancy of added implicit modifiers

A bit of clean-up

95f5808

- Making empty final -- and static even though static is redundant here - Removing unnecessary package qualification on forEach

dougqh requested a review from a team as a code owner December 10, 2025 22:33

dougqh requested a review from amarziali December 10, 2025 22:33

dougqh temporarily deployed to ci-build December 10, 2025 22:34 — with GitHub Actions Inactive

dougqh added type: enhancement Enhancements and improvements comp: core Tracer core labels Dec 10, 2025

amarziali reviewed Dec 11, 2025

View reviewed changes

spotless

79092b0

dougqh temporarily deployed to ci-build December 11, 2025 13:27 — with GitHub Actions Inactive

Merge branch 'master' into dougqh/tagmap-cleanup

13ad995

dougqh temporarily deployed to ci-build December 11, 2025 13:59 — with GitHub Actions Inactive

amarziali approved these changes Dec 11, 2025

View reviewed changes

Merge branch 'master' into dougqh/tagmap-cleanup

8026a5f

dougqh temporarily deployed to ci-build December 11, 2025 15:41 — with GitHub Actions Inactive

Merge branch 'master' into dougqh/tagmap-cleanup

854633b

dougqh temporarily deployed to ci-build December 11, 2025 20:33 — with GitHub Actions Inactive

AlexeyKuznetsov-DD approved these changes Dec 15, 2025

View reviewed changes

bric3 self-requested a review January 21, 2026 14:36

bric3 approved these changes Jan 21, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

A bit of clean-up in TagMap#10164

A bit of clean-up in TagMap#10164
dougqh wants to merge 5 commits intomasterfrom
dougqh/tagmap-cleanup

dougqh commented Dec 10, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 10, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Dec 10, 2025 •

edited

Loading

Uh oh!

amarziali Dec 11, 2025

Uh oh!

dougqh Dec 11, 2025

Uh oh!

amarziali Dec 11, 2025

Uh oh!

dougqh Dec 11, 2025 •

edited

Loading

Uh oh!

amarziali left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

dougqh commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

github-actions bot commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

amarziali Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

dougqh Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

amarziali Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

dougqh Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amarziali left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dougqh commented Dec 10, 2025 •

edited

Loading

github-actions bot commented Dec 10, 2025 •

edited

Loading

pr-commenter bot commented Dec 10, 2025 •

edited

Loading

dougqh Dec 11, 2025 •

edited

Loading